Update from Hummingbird Project Template #32
Conversation
![hummingbird-automation[bot]](https://avatars.githubusercontent.com/u/77961464?s=60&v=4){kind=small}
hummingbird-automation
bot
requested review from
adam-fowler,
Joannis and
thoven87
as code owners
scripts/validate.sh
Outdated
| ## | ||
| ##===----------------------------------------------------------------------===## | ||
| ##===----------------------------------------------------------------------===## | ||
| ## | ||
| ## This source file is part of the SwiftNIO open source project |
There was a problem hiding this comment.
Should this text be updated?
There was a problem hiding this comment.
We need to include the original NIO text, as that is what it was when I copied the file across. I've added a Hummingbird header because the file has been altered since then
scripts/validate.sh
Outdated
| ## | ||
| ##===----------------------------------------------------------------------===## | ||
| ##===----------------------------------------------------------------------===## | ||
| ## | ||
| ## This source file is part of the SwiftNIO open source project | ||
| ## | ||
| ## Copyright (c) 2017-2019 Apple Inc. and the SwiftNIO project authors |
|
Can the verify documentation step failed with libs that swift jobs is not dependent on? |
Yes, we need to get to a state where all docs are happy. The issue is docs can reference other packages so I have to build all docs at the same time. We were happy, but then swift 6 got released and swift 6 is super fussy about the function headers and now we have a load of errors which we need to fix in released builds. I have most of them fixed just haven't done releases |
hummingbird-automation
bot
force-pushed
the
project-template-update
branch
from
d857225 to
0412c4e
Compare
Automated update of files from https://github.com/hummingbird-project/hummingbird-project-template