Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tracing to job queue #49

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Add Tracing to job queue #49

merged 2 commits into from
Jan 8, 2025

Conversation

adam-fowler
Copy link
Member

The trace context of the current span is stored in the job metadata and then added as a link to the job span. This means you get a link to the span that triggered the job which could either be the original http request, or the previously failed attempt.

Copy link
Contributor

@thoven87 thoven87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks there are some conflicts that need to be resolved.

The link can either be the span context at the point jobQueue.push was called or the previous attempt at running this job.
@adam-fowler adam-fowler merged commit 7ec9be1 into main Jan 8, 2025
6 checks passed
@adam-fowler adam-fowler deleted the tracing branch January 8, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants