fix: missing space in jsx prop (#118)

huozhi · Jan 18, 2025 · 06fd073 · 06fd073
1 parent 19dded5
commit 06fd073
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 4 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -475,9 +475,19 @@ function tokenize(code, options) {
           if (isIdentifier(prop)) {
             current = prop
             append(T_PROPERTY)
+          } else if (prop === ' ') {
+            current = prop
+            append(T_SPACE)
           }
           continue
         }
+
+        // if (curr === ' ' || isSign(curr)) {
+        //   append()
+        //   current = curr
+        //   append()
+        //   continue
+        // }
       }
     }
 

diff --git a/test/ast.test.ts b/test/ast.test.ts
@@ -370,6 +370,33 @@ describe('jsx', () => {
     `)
   })
 
+  it('preserve spaces in arrow function jsx prop correctly', () => {
+    const code = '<Foo prop={(v) => 1)} />'
+
+    const tokens = tokenize(code)
+    expect(getTokensAsString(tokens, { filterSpaces: false })).toMatchInlineSnapshot(`
+      [
+        "< => sign",
+        "Foo => entity",
+        " => space",
+        "prop => property",
+        "= => sign",
+        "{ => sign",
+        "( => sign",
+        "v => identifier",
+        ") => sign",
+        "= => sign",
+        "> => sign",
+        " => space",
+        "1 => identifier",
+        ") => sign",
+        "} => sign",
+        " => space",
+        "/> => sign",
+      ]
+    `)
+  })
+
   it('should render string for any jsx attribute values', () => {
     const code = '<h1 data-title="true" />'
     const tokens = tokenize(code)

diff --git a/test/testing-utils.ts b/test/testing-utils.ts
@@ -26,15 +26,20 @@ function getTokenArray(tokens) {
   return tokens.map((tk) => [tk[1], getTypeName(tk)]);
 }
 
-function extractTokenArray(tokens) {
+function extractTokenArray(tokens, options: { filterSpaces?: boolean } = {}) {
+  const { filterSpaces = true } = options
   return tokens
     .map((tk) => [mergeSpaces(tk[1]), getTypeName(tk)])
-    .filter(([_, type]) => type !== 'space' && type !== 'break')
+    .filter(([_, type]) => 
+      filterSpaces
+        ? type !== 'space' && type !== 'break'
+        : true
+    )
 }
 
 // Generate the string representation of the tokens
-function getTokensAsString(tokens) {
-  const extracted = extractTokenArray(tokens)
+function getTokensAsString(tokens: any[], options: { filterSpaces?: boolean } = {}) {
+  const extracted = extractTokenArray(tokens, options)
   return extracted.map(([value, type]) => `${value} => ${type}`)
 }