Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Variable Views visible in FlatZinc #29

Merged
merged 8 commits into from
May 15, 2024
Merged

Conversation

Dekker1
Copy link
Contributor

@Dekker1 Dekker1 commented May 15, 2024

  • Change modelling layer for directly using Views in Model
  • Add detection for linear views in the FlatZinc
  • Add bool2int support through integer view
  • Add subject literal to Conflict type for non-root level conflicts
  • Update Solver Debug implementation
  • Update tracing for propagators

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 50.72727% with 271 lines in your changes are missing coverage. Please review.

Project coverage is 54.87%. Comparing base (82f6e52) to head (2699dfc).

Files Patch % Lines
crates/huub/src/model/flatzinc.rs 0.00% 87 Missing ⚠️
crates/huub/src/model/int.rs 22.03% 46 Missing ⚠️
crates/huub/src/solver/view.rs 13.33% 39 Missing ⚠️
crates/huub/src/model/reformulate.rs 57.14% 21 Missing ⚠️
crates/huub/src/model/bool.rs 45.94% 20 Missing ⚠️
crates/fzn-huub/src/tracing.rs 0.00% 17 Missing ⚠️
crates/huub/src/helpers/linear_transform.rs 77.04% 14 Missing ⚠️
...ates/huub/src/solver/engine/propagation_context.rs 75.00% 13 Missing ⚠️
crates/huub/src/model/constraint.rs 44.44% 5 Missing ⚠️
crates/huub/src/solver/engine.rs 94.20% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #29      +/-   ##
===========================================
+ Coverage    53.69%   54.87%   +1.17%     
===========================================
  Files           27       28       +1     
  Lines         2799     2954     +155     
===========================================
+ Hits          1503     1621     +118     
- Misses        1296     1333      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dekker1 Dekker1 merged commit 2699dfc into develop May 15, 2024
6 of 7 checks passed
@Dekker1 Dekker1 deleted the feat/flatzinc-views branch May 15, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant