Add interface for Feature2D detection algorithms #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 2c36353 Author: Pericles Telemachou <[email protected]> Date: Thu Oct 26 12:39:52 2023 +1100 Asserting some algorithms conform to `Feature2D` commit 665eef3 Author: Pericles Telemachou <[email protected]> Date: Thu Oct 26 12:39:04 2023 +1100 Add interface for `Feature2D` algorithms
pericles-tpt
force-pushed
the
feature2d-interface
branch
from
2c36353
to
0d03716
Compare
|
Sorry about the delayed response here.
Yes, please! |
|
We've updated the names of the Feature2D component interfaces, let us know if you have any feedback that you'd like us to work on to get it ready to merge |
|
Thank you very much for adding this @pericles-tpt now merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to query 4 in #1049, we added a
Feature2Dinterface and interface assertions to check at compile time that Feature2D detection algorithms implement required functionality. Interface assertions have been added for the following algorithms:Would you like us to namespace the component interfaces of
Feature2D, i.e.Detector,ComputerandDetectComputerwith aFeature2Dprefix?