Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when two or more windows #570

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix crash when two or more windows #570

wants to merge 1 commit into from

Conversation

Danile71
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 12, 2019

Codecov Report

Merging #570 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #570      +/-   ##
=========================================
+ Coverage   98.08%   98.1%   +0.01%     
=========================================
  Files          17      17              
  Lines        2092    2112      +20     
=========================================
+ Hits         2052    2072      +20     
  Misses         33      33              
  Partials        7       7
Impacted Files Coverage Δ
highgui.go 88.88% <100%> (+2.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d624e2c...e1799ac. Read the comment docs.

@Danile71
Copy link
Contributor Author

I founded bug:
When I start recieving video from 2 cameras and parallel drawing to 2 windows - I have crash.
With sync no bugs

@deadprogram
Copy link
Member

Makes sense given the way that OpenCV does all of the UI stuff thru a single thread. I think I tried doing something like this once, not sure why I did not continue?

What OS do you use @Danile71 for testing?

@deadprogram
Copy link
Member

This was one of the issues where thread safety was discussed: #191

@Danile71
Copy link
Contributor Author

I use ubuntu 18

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (d624e2c) to head (e1799ac).
Report is 410 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #570      +/-   ##
==========================================
+ Coverage   98.08%   98.10%   +0.01%     
==========================================
  Files          17       17              
  Lines        2092     2112      +20     
==========================================
+ Hits         2052     2072      +20     
  Misses         33       33              
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants