Meet host-defined functions registry #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both wasman and wazero allow to define functions that accept a slice of raw ValueType as input and return a slice of raw ValueType as output. In both cases, the raw representation is the same and uses uint64 as the underlying type. Also, wazero requires all functions in a module to be defined in one go.
To solve code duplication issues and avoid using reflection in wazero, this PR introduces a Modules registry:
The registry is not used in any way in this PR yet but it will be used something like this (which will replace the current
DefineFunc
):