kill process after test is over

hyperf · Mar 27, 2020 · 3b77228 · 3b77228
1 parent b904a01
commit 3b77228
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 8 deletions.
diff --git a/src/LocalGoTask.php b/src/LocalGoTask.php
@@ -57,8 +57,6 @@ private function start()
             } catch (\Throwable $e){
                 $returnChannel->push($e);
             }
-
-
         }
     }
 }
diff --git a/tests/Cases/CoroutineSocketTest.php b/tests/Cases/CoroutineSocketTest.php
@@ -36,23 +36,28 @@
 class CoroutineSocketTest extends AbstractTestCase
 {
     const UNIX_SOCKET = '/tmp/test.sock';
-
     /**
-     * @var RPC
+     * @var Process
      */
-    private $task;
+    private $p;
 
     public function setUp()
     {
         ! defined('BASE_PATH') && define('BASE_PATH', dirname(__DIR__, 1));
         @unlink(self::UNIX_SOCKET);
-        $p = new Process(function (Process $process)  {
-            $process->exec(__DIR__ . '/../../app', ['-address', self::UNIX_SOCKET, '-standalone']);
+        $this->p = new Process(function (Process $process)  {
+            $process->exec(__DIR__ . '/../../app', ['-address', self::UNIX_SOCKET]);
         });
-        $p->start();
+        $this->p->start();
         sleep(1);
     }
 
+    public function tearDown()
+    {
+        Process::kill($this->p->pid);
+    }
+
+
     public function testOnCoroutine()
     {
         \Swoole\Coroutine\run(function () {

diff --git a/tests/Cases/IPCRelayTest.php b/tests/Cases/IPCRelayTest.php
@@ -29,6 +29,11 @@ public function setUp()
         sleep(1);
     }
 
+    public function tearDown()
+    {
+        Process::kill($this->p->pid);
+    }
+
     public function testOnCoroutine()
     {
         \Swoole\Coroutine\run(function () {