-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reduce error size by boxing some errors #5577
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5577 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
I would like to understand better why we need to reduce the error sizes, what is the driver for the change? Possibly, it is worth to update the description of the PR. minor: We don't need irrelevant empty sections in the description since they will be pushed as commit comment and will stay forever in the change history. |
|
Description
The purpose of this is to reduce memory usage for our agents. When trying to migrate to rust2024, it warned about certain error types being unnecessarily large and recommended us to box some error types to reduce memory footprint.
I set
clippy.toml
during development to:Then ran clippy. Then reduced all the errors that was showing a warning by boxing them.
VS Code mouse hover was also able to show size of different errors. But it wasn't able to for some error types :/
Backward compatibility
Yes
Testing
None