Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mar5 testnet updates #5620

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat: mar5 testnet updates #5620

wants to merge 18 commits into from

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Mar 6, 2025

Description

  • deploy to carrchaintestnet, somniatestnet, infinityvmmonza
  • remove berabartio, which is already set for sunset

Drive-by changes

Related issues

hyperlane-xyz/hyperlane-registry#649

Backward compatibility

Testing

manual

Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: fb5f79b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/cli Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/ccip-server Patch
@hyperlane-xyz/github-proxy Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/utils Patch
@hyperlane-xyz/widgets Patch
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (7c95140) to head (fb5f79b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5620   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paulbalaji paulbalaji marked this pull request as ready for review March 7, 2025 13:37
@@ -24,6 +24,16 @@ export const chainMetadataOverrides: ChainMap<Partial<ChainMetadata>> = {
// gasPrice: 0.5 * 10 ** 9, // 0.5 gwei
// },
// },
// somniatestnet: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these need to stay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, hence commented out as deploy-only overrides

Comment on lines +191 to +192
// Temporary workaround due to InfinityVM Monza whitelisting.
{ destinationDomain: getDomainId('infinityvmmonza') },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure how necessary this is

@@ -46,6 +46,7 @@ export const keyFunderConfig: KeyFunderConfig<
fuji: '5',
holesky: '5',
hyperliquidevmtestnet: '0.1',
infinityvmmonza: '0',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it's whitelisted, will need to update if we get gas tokens

@@ -51,6 +51,12 @@ export async function proxyAdmin(
proxy,
'0xb53127684a568b3173ae13b9f8a6016e243e63b6e8ee1178d6a717850b5d6103',
);

// Return zero address if storage value is empty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the context for this change?

Copy link
Contributor Author

@paulbalaji paulbalaji Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on somnia the ethers.utils.getAddress(storageValue.slice(26)) was causing problems as the storageValue returned was 0x and not a full padded value. essentially it was doing getAddress(''). this change was a defensive addition that i believe shouldn't break any existing flows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants