-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mar5 testnet updates #5620
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: fb5f79b The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5620 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
🚀 New features to boost your workflow:
|
@@ -24,6 +24,16 @@ export const chainMetadataOverrides: ChainMap<Partial<ChainMetadata>> = { | |||
// gasPrice: 0.5 * 10 ** 9, // 0.5 gwei | |||
// }, | |||
// }, | |||
// somniatestnet: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these need to stay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, hence commented out as deploy-only overrides
// Temporary workaround due to InfinityVM Monza whitelisting. | ||
{ destinationDomain: getDomainId('infinityvmmonza') }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsure how necessary this is
@@ -46,6 +46,7 @@ export const keyFunderConfig: KeyFunderConfig< | |||
fuji: '5', | |||
holesky: '5', | |||
hyperliquidevmtestnet: '0.1', | |||
infinityvmmonza: '0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it's whitelisted, will need to update if we get gas tokens
@@ -51,6 +51,12 @@ export async function proxyAdmin( | |||
proxy, | |||
'0xb53127684a568b3173ae13b9f8a6016e243e63b6e8ee1178d6a717850b5d6103', | |||
); | |||
|
|||
// Return zero address if storage value is empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the context for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on somnia the ethers.utils.getAddress(storageValue.slice(26))
was causing problems as the storageValue
returned was 0x
and not a full padded value. essentially it was doing getAddress('')
. this change was a defensive addition that i believe shouldn't break any existing flows
Description
Drive-by changes
Related issues
hyperlane-xyz/hyperlane-registry#649
Backward compatibility
Testing
manual