feat: Add parseGitHubPath() to parse URI in GithubRegistry #656
+161
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 281fc76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nambrot
reviewed
Mar 7, 2025
|
|
||
| this.repoOwner = repoOwner; | ||
| this.repoName = repoName; | ||
| this.branch = options.branch ?? repoBranch ?? 'main'; |
There was a problem hiding this comment.
Shouldn't we raise an error if both options.branch and repoBranch are passed?
test/unit/registry.test.ts
Outdated
| useProxy: true, | ||
| expectedRegistries: [ | ||
| { type: GithubRegistry, uri: DEFAULT_GITHUB_REGISTRY, proxyUrl: PROXY_DEPLOYED_URL }, | ||
| { type: FileSystemRegistry, uri: localPath }, | ||
| { type: GithubRegistry, uri: 'https://github.com/test' }, | ||
| { type: GithubRegistry, uri: 'https://github.com/user/test' }, |
There was a problem hiding this comment.
Can you add a test case here that includes the branch in the URL?
ltyu
force-pushed
the
ltyu/parse-branch-from-uri
branch
from
abeed73 to
55e7409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update GithubRegistry to be able to parse branch from URI by using a helper function. The function uses regex instead of split/positional arrays because we may have branches that look like:
ltyu/REZ/base-ethereumDrive-by
Some lint updates
Backward compatibility
Yes - moved the existing parsing logic to a helper function that uses regex instead of positional arrays.
Testing
Unit test