Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

fix: did:sov urls changed out for github urls #90

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

PeterStrob
Copy link
Contributor

did:sov urls changed out for github urls

Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple instances that need to be reverted

int/scripts/openapi.yml Outdated Show resolved Hide resolved
int/tests/test_basicmessage.py Outdated Show resolved Hide resolved
dbluhm
dbluhm previously approved these changes Sep 21, 2021
@TheTechmage
Copy link
Contributor

All of these are referring to tree/master. The Hyperledger project has chosen (from my understanding) to rename all master branches to main. Would you be able to switch all of them to point to main instead of master? Does doing that break anything? The reason why I am asking is because it will ensure that the paths are consistent with the repos themselves and ensure that they work if GitHub decides to ever remove their master->main backwards compatibility for repositories.

Aside from that, I think the change looks good to me. The tests on the other hand seem less convinced.

@dbluhm
Copy link
Contributor

dbluhm commented Oct 14, 2021

All of these are referring to tree/master. The Hyperledger project has chosen (from my understanding) to rename all master branches to main. Would you be able to switch all of them to point to main instead of master? Does doing that break anything? The reason why I am asking is because it will ensure that the paths are consistent with the repos themselves and ensure that they work if GitHub decides to ever remove their master->main backwards compatibility for repositories.

You raise some good points. I think if we're in the process of changing these already, it may make sense to coordinate a cut over for this as well. This change may be something we want to raise on the Aries WG call before merging to provide some warning to potential users that this change is taking place and will impact compatibility.

@dbluhm
Copy link
Contributor

dbluhm commented Oct 14, 2021

Thoughts on how best to apply these changes, @TelegramSam?

@dbluhm
Copy link
Contributor

dbluhm commented Mar 1, 2022

On further consideration, we should make it possible to accept either the old message type or the new message type. This will also ease questions surrounding breaking changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants