-
Notifications
You must be signed in to change notification settings - Fork 40
fix: did:sov urls changed out for github urls #90
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple instances that need to be reverted
9af9ede
to
d813247
Compare
All of these are referring to tree/master. The Hyperledger project has chosen (from my understanding) to rename all Aside from that, I think the change looks good to me. The tests on the other hand seem less convinced. |
You raise some good points. I think if we're in the process of changing these already, it may make sense to coordinate a cut over for this as well. This change may be something we want to raise on the Aries WG call before merging to provide some warning to potential users that this change is taking place and will impact compatibility. |
Thoughts on how best to apply these changes, @TelegramSam? |
On further consideration, we should make it possible to accept either the old message type or the new message type. This will also ease questions surrounding breaking changes. |
did:sov urls changed out for github urls