Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle in-flight messages during Kafka failover #44

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Conversation

peterbroadhurst
Copy link
Contributor

Fix for #43

From the logs you can see Consumer session cleanup happened (due to a Kafka failover event) while there was an in-flight consumer inserting into the receipt store. When it came to acknowledge the message, the session had already been cleaned up.

So we simply need to ignore the request to mark the message - as the session is stale. We will be re-delivered that batch after the consumer session failover completes.

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #44 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #44      +/-   ##
=========================================
+ Coverage    97.6%   97.6%   +<.01%     
=========================================
  Files          48      48              
  Lines        5086    5088       +2     
=========================================
+ Hits         4964    4966       +2     
  Misses         85      85              
  Partials       37      37
Impacted Files Coverage Δ
internal/kldkafka/client.go 77.77% <100%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc13837...3016f67. Read the comment docs.

Copy link
Contributor

@jimthematrix jimthematrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jimthematrix jimthematrix merged commit c9c6b97 into master Jan 24, 2020
@jimthematrix jimthematrix deleted the issue-43 branch January 24, 2020 20:16
awrichar pushed a commit that referenced this pull request Jun 7, 2021
Default polling interval of 1s (not 10ms)

Signed-off-by: Galen Keene <[email protected]>
awrichar pushed a commit that referenced this pull request Jun 7, 2021
Handle in-flight messages during Kafka failover

Signed-off-by: Jim Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants