REST API viewer shows ":undefined" for type on empty inputs/outputs #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a fix for #66 to this PR. |
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 97.90% 97.86% -0.04%
==========================================
Files 50 50
Lines 5346 5347 +1
==========================================
- Hits 5234 5233 -1
Misses 81 81
- Partials 31 33 +2
Continue to review full report at Codecov.
|
vdamle
approved these changes
Apr 20, 2020
awrichar
pushed a commit
that referenced
this pull request
Jun 7, 2021
) * REST API viewer shows ":undefined" for type on empty inputs/outputs * Fix intermittent test by moving duplicate check to separate test Signed-off-by: Peter Broadhurst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling a contract with methods that have no inputs or no outputs (such as a default constructor) the OpenAPI renders with a confusing
:undefinedoutput - because we do not include"type": "object"in the empty schema defintiion.