Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: VPJWT JSON decoder in the issue-credential protocol #1505

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

yshyn-iohk
Copy link
Member

@yshyn-iohk yshyn-iohk commented Jan 23, 2025

Description:

  • fix the JSON decoder in the VPJWT object of the issue-credential protocol

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link
Contributor

Integration Test Results

 23 files  ±0   23 suites  ±0   3s ⏱️ ±0s
 56 tests ±0   56 ✅ ±0  0 💤 ±0  0 ❌ ±0 
103 runs  ±0  103 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3dbc7ee. ± Comparison against base commit fa1c04f.

Copy link
Contributor

Unit Test Results

105 files  ±0  105 suites  ±0   20m 24s ⏱️ +12s
889 tests ±0  881 ✅ ±0  8 💤 ±0  0 ❌ ±0 
896 runs  ±0  888 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 3dbc7ee. ± Comparison against base commit fa1c04f.

@coveralls
Copy link

Coverage Status

coverage: 48.657% (-0.07%) from 48.723%
when pulling 3dbc7ee on fix/vpjwt-jsondecoder
into fa1c04f on main.

@yshyn-iohk yshyn-iohk merged commit d16da04 into main Jan 24, 2025
17 of 18 checks passed
@yshyn-iohk yshyn-iohk deleted the fix/vpjwt-jsondecoder branch January 24, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants