Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run clippy on guests in CI #237

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Feb 4, 2025

closes #217 by running cargo clippy on the guests in CI. Also fixes existing clippy violations that have snuck in. Note that the change from i64->usize is a breaking change

@ludfjig ludfjig marked this pull request as draft February 4, 2025 21:08
@ludfjig ludfjig force-pushed the clippy_guests branch 2 times, most recently from 4be0e64 to 3a1be12 Compare February 4, 2025 22:10
@ludfjig ludfjig changed the title Clippy guests Run clippy on guests in CI Feb 4, 2025
Signed-off-by: Ludvig Liljenberg <[email protected]>
@ludfjig ludfjig marked this pull request as ready for review February 5, 2025 23:09
@simongdavies
Copy link
Contributor

Related to the change from i64 -> usize #216

simongdavies
simongdavies previously approved these changes Feb 6, 2025
Signed-off-by: Ludvig Liljenberg <[email protected]>
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run clippy on the test guests
3 participants