Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restoring Gosh and Hartree Slater GOS #32

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Mar 17, 2024

As noticed in hyperspy/exspy-demos#3 (comment), the eels core loss edge are not restored correctly. This is because subshell_factor was missing from the whitelist and therefore its value wasn't restored correctly.

Progress of the PR

  • Add subshell_factor to the whitelist of EELS core loss edge component,
  • [n/a] docstring updated (if appropriate),
  • [n/a] update user guide (if appropriate),
  • added tests,
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:exspy build of this PR (link in github checks)
  • ready for review.

…ing from the `whitelist` and therefore its value wasn't restored
@ericpre ericpre added this to the v0.2 milestone Mar 17, 2024
@ericpre ericpre added bug Something isn't working bug-fix labels Mar 17, 2024
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (eb65577) to head (df90ec6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   88.07%   88.45%   +0.38%     
==========================================
  Files          67       67              
  Lines        7276     7295      +19     
  Branches     1179     1179              
==========================================
+ Hits         6408     6453      +45     
+ Misses        591      573      -18     
+ Partials      277      269       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaehne jlaehne merged commit c37013c into hyperspy:main Mar 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants