Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nion15update #4

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

nion15update #4

wants to merge 14 commits into from

Conversation

ltizei
Copy link

@ltizei ltizei commented Oct 6, 2020

The major change was to the init(self, file_path) method. If I understand correctly this:
'''
else:
r = Profile.FolderProjectReference()
r.project_folder_path = file_path
'''
should take care of older libraries, but it does not seem to work. When ran with a valid nion library path, it does not raise an error, but the associated project in r.project has .data_items empty.

Otherwise, it works for nionswift=0.15.1 projects.

@ltizei
Copy link
Author

ltizei commented Sep 18, 2021

I made a mistake, I was trying to merge my branches in my repository.

@francisco-dlp francisco-dlp mentioned this pull request Oct 25, 2022
@francisco-dlp
Copy link
Member

Thanks @ltizei! I'll merge this as-is and merge a follow-up #5 just after. Sorry that it has taken me so long to come back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants