Add explicit Cache-Control, to make sure Cloudflare does not cache resources for too long #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
commented
Jun 5, 2023
| try_files $uri $uri/ /index.html$is_args$args; | ||
| # Ensure Cloudflare caches assets for 5 minutes | ||
| add_header Cache-Control "public, s-maxage=300, max-age=60, must-revalidate"; | ||
| try_files $uri $uri/ /index.html; |
There was a problem hiding this comment.
I have removed $is_args$args, because those actually make no sense when loading a static file. They are meant to be used in fast-cgi contexts, like with PHP and such, where there might be some server-side logic run before nginx returns the result.
acelaya
commented
Jun 5, 2023
| @@ -12,12 +12,15 @@ server { | |||
|
|
|||
| # When requesting static paths with an extension, try them, and return a 404 if not found | |||
| location ~* .+\..+ { | |||
| add_header Cache-Control "public, s-maxage=300, max-age=60, must-revalidate"; | |||
There was a problem hiding this comment.
For now, I have just set the same values we have for the client assets.
…sources for too long
acelaya
force-pushed
the
patterns-deployment-naive-cache
branch
from
d0ad597
to
f9c7215
Compare
|
This PR is superseded by #1089 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we implement a better solution, this PR adds explicit 5 minute cache for any resource served through the pattern library production nginx (index.html, CSS/JS bundles, and any other static resource).
This will make sure Cloudflare revalidates those assets after 5 minutes tops, and we don't end-up showing outdated content after a deployment.
Next steps would include improving this process to make it smarter (cache longer what doesn't change, while making sure new content is displayed right away after a deployment). We have discussed a few options on slack https://hypothes-is.slack.com/archives/C1M8NH76X/p1685957404405389
Testing steps
docker build . -t hypothesis_frontend_shared.docker run --rm -p 89:5001 hypothesis_frontend_sharedCache-Control: public, s-maxage=300, max-age=60, must-revalidate.