Do not set height classes in ModalDialog when size is 'custom' #1443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hypothesis/client#6151 and hypothesis/client#6158
Depends on #1442
All
ModalDialog
instances have currently these hardcoded classes:max-w-[90vw] max-h-[90vh]
-> Ensure they don't span more than 90% of the viewport's width and height.tall:fixed tall:max-h-[80vh] tall:top-[10vh]
-> When the screen is tall ((min-height: 32rem)
), ensure a fixed position of the modal.This usually makes sense, as these play nicely with the regular sizes. However, when providing
custom
size, the classes which affect vertical size and positioning can get in the way and force you to override them with other classes including the important modifier (!
).This PR changes that behavior to make those classes be skipped when
size
iscustom
, so that consumer code has more control over how it behaves.This is technically speaking a breaking change, but we are currently not using custom size modals in downstream projects.
The main motivation for this change is being able to use
ModalDialog
for the client's notebook, and benefit from its accessibility afordances.