Move URLMigrationService annotation queries to annotations service
#7929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 6, 2023 14:29
… queries This also involves basically re-doing the tests. This moves to a style which attempts to test the method in order of the calls, instead of separate tests for every element, which is much more compact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For:
This PR moves the queries that the
URLMigrationServicemakes to retrieve annotation to the annotation service. This accumulates related code in the same place and simplifies theURLMigrationServiceand it's tests.This also paves the way to replace the
update_annotationcall made inURLMigrationServicewith a method in the annotation service as well.