Move update_annotation to the annotation service
#7930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-betts
commented
Apr 6, 2023
| raise ValidationError( | ||
| "group scope: " | ||
| + _("Annotations for this target URI are not allowed in this group") | ||
| ) |
There was a problem hiding this comment.
This is a different formulation than the original because when done this way it can be re-used for create_annotation
jon-betts
commented
Apr 6, 2023
| for key, value in data.items(): | ||
| # Don't set complex things | ||
| if key in ("document", "extra"): | ||
| continue |
There was a problem hiding this comment.
In the previous version we relied on popping values at certain point, which coupled the code and made changing seemingly unconnected line order break the method.
Now these methods are separate, and can be thought of independently.
jon-betts
force-pushed
the
storage-update-annotation
branch
3 times, most recently
from
01152e6
to
baf47b8
Compare
jon-betts
force-pushed
the
storage-update-annotation
branch
from
baf47b8
to
874832c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: