-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration for annotation.pk #8154
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
"""Add pk to the annotation table.""" | ||
import sqlalchemy as sa | ||
from alembic import op | ||
from sqlalchemy.schema import CreateSequence, DropSequence, Sequence | ||
|
||
revision = "f064c2b2e04a" | ||
down_revision = "95825c951c08" | ||
|
||
|
||
def upgrade(): | ||
op.execute(CreateSequence(Sequence("annotation_id_seq"))) | ||
op.add_column("annotation", sa.Column("pk", sa.Integer(), nullable=True)) | ||
|
||
# CONCURRENTLY can't be used inside a transaction. Finish the current one. | ||
op.execute("COMMIT") | ||
# Create index for the constraint first, concurrently | ||
op.execute( | ||
"""CREATE UNIQUE INDEX CONCURRENTLY ix__annotation__pk ON annotation (pk);""" | ||
) | ||
# Use the now existing index to create the constraint. It will be renamed in this process | ||
op.execute( | ||
"""ALTER TABLE annotation ADD CONSTRAINT uq__annotation__pk UNIQUE USING INDEX ix__annotation__pk;""" | ||
) | ||
|
||
|
||
def downgrade(): | ||
op.drop_constraint(op.f("uq__annotation__pk"), "annotation", type_="unique") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For deletion we can use alembic own syntax. |
||
op.drop_column("annotation", "pk") | ||
op.execute(DropSequence(Sequence("annotation_id_seq"))) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nullable column