Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration for annotation.pk #8154

Merged
merged 1 commit into from
Sep 8, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions h/migrations/versions/f064c2b2e04a_annotation_pk.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
"""Add pk to the annotation table."""
import sqlalchemy as sa
from alembic import op
from sqlalchemy.schema import CreateSequence, DropSequence, Sequence

revision = "f064c2b2e04a"
down_revision = "95825c951c08"


def upgrade():
op.execute(CreateSequence(Sequence("annotation_id_seq")))
op.add_column("annotation", sa.Column("pk", sa.Integer(), nullable=True))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nullable column


# CONCURRENTLY can't be used inside a transaction. Finish the current one.
op.execute("COMMIT")
# Create index for the constraint first, concurrently
op.execute(
"""CREATE UNIQUE INDEX CONCURRENTLY ix__annotation__pk ON annotation (pk);"""
)
# Use the now existing index to create the constraint. It will be renamed in this process
op.execute(
"""ALTER TABLE annotation ADD CONSTRAINT uq__annotation__pk UNIQUE USING INDEX ix__annotation__pk;"""
)


def downgrade():
op.drop_constraint(op.f("uq__annotation__pk"), "annotation", type_="unique")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For deletion we can use alembic own syntax.

op.drop_column("annotation", "pk")
op.execute(DropSequence(Sequence("annotation_id_seq")))