Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to add existing group creators as owners #9031

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seanh
Copy link
Contributor

@seanh seanh commented Oct 18, 2024

Depends on #9032

@seanh seanh requested a review from marcospri October 18, 2024 15:56
@seanh seanh changed the title owner role migration Add migration to add existing group creators as owners Oct 18, 2024
Comment on lines +36 to +47
op.execute(
update(user_group_table)
.where(
user_group_table.c.id.in_(
select(user_group_table.c.id)
.where(user_group_table.c.group_id == group_table.c.id)
.where(user_group_table.c.user_id == user_table.c.id)
.where(user_table.c.id == group_table.c.creator_id)
)
)
.values(roles=["owner"])
)
Copy link
Contributor Author

@seanh seanh Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all existing groups will have creators. There are three cases:

  1. The user account of the group's creator has been deleted. In this case "group".creator_id is NULL. There's nothing to do in this case.
  2. The creator is no longer a member of the group. In this case "group".creator_id will still correspond to an existing "user".id but there will be no user_group row with a matching group_id and user_id. Again there's nothing to do in this case.
  3. The creator is still a member of the group. In this case we find the right user_group row and update roles to ["owner"].

And of course we need to not update user_group roles for non-creator memberships.

I'm hoping I can get away with updating all the rows at once as in the SQL query above. In the production DB there are 191,571 rows matching:

SELECT count(*)
FROM "group", "user", user_group
WHERE
  "group".id = user_group.group_id
  AND "user".id = user_group.user_id
  AND "group".creator_id = "user".id;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping I can get away with updating all the rows at once as in the SQL query above. In the production DB there are 191,571 rows matching:

I reckon it would be fine but we should run it early in the morning just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants