Store LTI1.3 context_memberships_url in LMSCourse when available #6606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
changed the base branch from
membership_url_migration
to
membership_url_model
This was referenced Aug 27, 2024
marcospri
changed the title
27 tasks
marcospri
commented
Aug 27, 2024
| @@ -75,8 +76,7 @@ def get_from_launch(self, product_family: Family, lti_params) -> Course: | |||
| historical_course = self._get_copied_from_course(lti_params) | |||
|
|
|||
| return self.upsert_course( | |||
| context_id=lti_params["context_id"], | |||
| name=lti_params["context_title"], | |||
| lti_params=lti_params, | |||
There was a problem hiding this comment.
Pass the full LTIParams here instead of just special casing title and id.
marcospri
commented
Aug 27, 2024
| ): | ||
| get_by_context_id.return_value = None | ||
|
|
||
| course = svc.get_from_launch( | ||
| Product.Family.CANVAS, |
There was a problem hiding this comment.
Using a common fixture in a few of the existing tests
acelaya
approved these changes
Aug 27, 2024
marcospri
force-pushed
the
membership_url_model
branch
from
676c5ec
to
68ce94d
Compare
Make v13 a dict in all cases to simplify access when accessing LTI1.3 properties.
Store LTI1.3 context_memberships_url in LMSCourse when available. This will allow us to comunicate with the service outside the launch context. See: https://www.imsglobal.org/spec/lti-nrps/v2p0#lti-1-3-integration
marcospri
force-pushed
the
membership_url_code
branch
from
a01a9a1
to
b27f9f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For:
Store the url of the LTI1.3 context membership service.
This will allow us to call it outside the scope of a launch. It will also, more immediately, give us a good indication of for how many courses we receive this information at the moment.
Testing
Launch https://hypothesis.instructure.com/courses/125/assignments/873, nothing changes, nothing explodes.
Launch an LTI1.3 assignment, https://hypothesis.instructure.com/courses/319/assignments/3308
The service URL gets recorded in the LMSCourse table:
select * from lms_course where lti_context_memberships_url is not null