Take and forward an optional assignment id in the LTI Name and Roles API #6617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
commented
Sep 2, 2024
| @@ -1,9 +1,6 @@ | |||
| """ | |||
| Service to talk to the Name and Roles LTIA API. | |||
|
|
|||
| We only implement this now as a way to obtain the LTI Advantage Complete | |||
marcospri
commented
Sep 2, 2024
| """ | ||
| query = {} | ||
| if resource_link_id: | ||
| query["rlid"] = resource_link_id |
There was a problem hiding this comment.
rlid is the name in the API but that's a bit cryptic. It's called resource link ID everywhere else.
There was a problem hiding this comment.
Perhaps add a comment there to clarify that for the next person? Even adding a link to some documentation would be good, if such thing exists.
There was a problem hiding this comment.
Yes, added a note to the issue for this, I'll do a follow up to avoid some rebase hell.
marcospri
force-pushed
the
names-roles-resource-link
branch
from
0f7ee52
to
e7e87a4
Compare
27 tasks
marcospri
force-pushed
the
names-roles-resource-link
branch
from
e7e87a4
to
c59cef8
Compare
acelaya
approved these changes
Sep 3, 2024
| """ | ||
| query = {} | ||
| if resource_link_id: | ||
| query["rlid"] = resource_link_id |
There was a problem hiding this comment.
Perhaps add a comment there to clarify that for the next person? Even adding a link to some documentation would be good, if such thing exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For:
Pass the value to the LTI service which should return only the roster relevant to the assignment.
More context and testing instructions over: