Display amount of items in dashboard filters #6820
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lms/static/scripts/frontend_apps/components/dashboard/DashboardActivityFilters.tsx
Outdated
Show resolved
Hide resolved
acelaya
force-pushed
the
dashboard-filters-amounts
branch
8 times, most recently
from
8d2991d
to
34fea0d
Compare
acelaya
force-pushed
the
dashboard-filters-amounts
branch
from
34fea0d
to
1f9e9a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the amount of items in a dashboard filter when that filter does not have a selected value.
This will help users know the items in those filters get filtered when selecting anything in the other filters.
Since filters are paginated, when the amount of items is equal or greater than the page size, we assume there are potentially more items and simply display "99+" (100 is the page size).