Skip to content

Commit

Permalink
Remove a couple of misleading comments
Browse files Browse the repository at this point in the history
It's best not to add unnecessary code comments like this: they're not
actually accurate (there are multiple required params after the `#
Optional` comment), and the code is clear enough without the comments
anyway.
  • Loading branch information
seanh committed Jul 18, 2023
1 parent aa32c94 commit a89f260
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions via/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,13 @@
from via.sentry_filters import SENTRY_FILTERS

PARAMETERS = {
# Required
"client_embed_url": {"required": True},
"nginx_server": {"required": True},
"via_html_url": {"required": True},
"checkmate_url": {"required": True},
"via_secret": {"required": True},
"checkmate_api_key": {"required": True},
"nginx_secure_link_secret": {"required": True},
# Optional
"checkmate_ignore_reasons": {},
"checkmate_allow_all": {"formatter": asbool},
"dev": {"formatter": asbool},
Expand Down

0 comments on commit a89f260

Please sign in to comment.