-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a client for getting data from YouTube #1100
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-betts
added
wip
technical enabler
Work which only serves to enable other work
labels
Jul 19, 2023
This was referenced Jul 19, 2023
jon-betts
force-pushed
the
yt-cc-client
branch
3 times, most recently
from
July 20, 2023 17:11
d5ab4ab
to
175df95
Compare
Labeling this as blocked just because it's waiting for me to get some more urgent PRs done before I can review this. I promise I'm working my way round to reviewing this ASAP! |
jon-betts
force-pushed
the
yt-cc-model-2
branch
4 times, most recently
from
August 2, 2023 18:57
7aa0421
to
7830357
Compare
jon-betts
force-pushed
the
yt-cc-model-2
branch
from
August 2, 2023 19:17
73c9415
to
a11f1e2
Compare
jon-betts
force-pushed
the
yt-cc-client
branch
2 times, most recently
from
August 2, 2023 19:28
0a7ed32
to
5ec410d
Compare
jon-betts
force-pushed
the
yt-cc-model-2
branch
from
August 2, 2023 19:34
7542f92
to
2543c70
Compare
jon-betts
force-pushed
the
yt-cc-model-2
branch
from
August 3, 2023 14:05
2543c70
to
aebdea5
Compare
Closing in favour of #1162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
Review notes
This PR uses an undocumented API for getting the JSON information. It seems the same data as the HTML scraping method, but avoids:
This is all being done a bit skin of the teeth. I'd ideally like to try more error scenarios, but I guess we'll catch them later.
The one I've spotted so far is that asking for a translated
Testing notes
You can play about as you'd like, but here is something to get you started.