Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply updates from cookiecutter #1161

Closed
wants to merge 1 commit into from
Closed

Conversation

hypothesis-github-app[bot]
Copy link

This automated pull request applies the latest updates from our cookiecutters to this repo.

We use our cookiecutter templates to automatically generate the boilerplate files in our repos. A GitHub Actions workflow sends pull requests like this one to apply recent cookiecutter changes to the files in our repos.

Does this pull request break anything? This is an automated pull request so it might have messed something up in this repo, so please check that everything looks good before merging. To understand the changes in this pull request it might help to review recently merged pull requests in the cookiecutters repo or to look at the cookiecutters repo's commit history. If there's something that looks wrong or that you don't understand you can ask the authors of the responsible cookiecutters repo commits.

For technical details of how these automated pull requests work see our GitHub App's page.

@seanh seanh self-assigned this Aug 4, 2023
This automated commit applies the latest updates from our cookiecutters [1] to
this repo.

[1]: https://github.com/hypothesis/cookiecutters
@@ -4,7 +4,6 @@
from alembic import context
from sqlalchemy import engine_from_config, pool

from via import models
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add this models import to the cookiecutter so that make template won't remove this line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanh seanh added the blocked label Aug 4, 2023
@seanh seanh closed this Aug 16, 2023
@seanh seanh deleted the cookiecutter branch August 16, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant