-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi scheduler support #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Document picker in README * Use pydantic to validate config file * Use context for file system/scheduler/picker instances * Split config, context, picker into own files * fix circular imports using TYPE_CHECKING if
As it requires sub dir in /tmp which is properly isolated
No need to mark it as private.
* uvicorn --reload was causing high load, so upgraded it. * httptools was not used anywhere so dropped. Also add more todos
Use if TYPE_CHECKING to prevent circular imports
Peter9192
reviewed
Jan 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished going through the code, will continue with some tests
Co-authored-by: Peter Kalverla <[email protected]>
Peter9192
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests mostly work fine, only check that job root dir exists doens't work for default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses configuration file to specify applications, schedulers and filesystems.
By default uses first scheduler and first filesystem to upload input, submit, state fetch, download output.
To test the multi scheduler support you have to create a config.yaml file by copying config-example.yaml. The example config file uses a in-memory scheduler on the local file system. To use the Slurm scheduler and sftp filesystem
slurmcontainer
block and/home/xenon/<job_id>
, which you can verify withdocker exec <container id> ls -l /home/xenon/<job_id>
sacct
to see the completed job.bartender serve
is running, which you can verify withls /tmp/jobs/*
, it should have a stdout.txt file.Also