Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline #9

Merged
merged 12 commits into from
Sep 20, 2024
Merged

Offline #9

merged 12 commits into from
Sep 20, 2024

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Sep 19, 2024

Solves haddocking/haddock3#1025 (comment)

TODO

  • host css somewhere
    1. Host on npmjs and get via jsdeliver, unpkg
    2. Host on GH release
    3. Host on GH pages
  • host bundle somewhere
    1. Host on npmjs and get via jsdeliver, unpkg
    2. Host on GH release
    3. Host on GH pages
  • decide to use
    1. embedded, css and js inside html, con big html file 1.4Mb, pro standalone (except urls to pdb files still need to resolve)
    2. or offline, css and js file imported in html, pro js/css files can be reused between report.html files

sverhoeven and others added 3 commits September 18, 2024 10:03
TODO
- python wrapper
Use similar html as haddock3.libs.libplots Python module generates.
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.46%. Comparing base (0dbdf82) to head (308e652).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   15.05%   24.46%   +9.41%     
==========================================
  Files          15       16       +1     
  Lines         372      376       +4     
  Branches       84       84              
==========================================
+ Hits           56       92      +36     
+ Misses        233      205      -28     
+ Partials       83       79       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sverhoeven sverhoeven marked this pull request as ready for review September 20, 2024 08:00
@sverhoeven sverhoeven merged commit 6ad8217 into main Sep 20, 2024
2 checks passed
@sverhoeven sverhoeven deleted the build-offline branch September 20, 2024 08:56
@sverhoeven
Copy link
Member Author

Picked js and css file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant