Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Documentation #639

Merged
merged 19 commits into from
Feb 10, 2025
Merged

Updating Documentation #639

merged 19 commits into from
Feb 10, 2025

Conversation

anawas
Copy link
Collaborator

@anawas anawas commented Jan 23, 2025

As we seem to be working towards a Karabo version 1.0 I'm about to update the documentation.
What I did so far:

  • Add documentation to many modules in karabo.util package
  • Rewriting of many docstring to the Google format.

@anawas anawas requested review from Lukas113 and mpluess February 7, 2025 12:26
@anawas anawas marked this pull request as ready for review February 7, 2025 12:26
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.19%. Comparing base (eee7ab3) to head (ba5e0e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
karabo/util/math_util.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #639   +/-   ##
=======================================
  Coverage   71.19%   71.19%           
=======================================
  Files          55       55           
  Lines        5946     5947    +1     
=======================================
+ Hits         4233     4234    +1     
  Misses       1713     1713           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Lukas113 Lukas113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two mentions:

Pydocstyle is deprecated, Ruff should be used instead (since you made changes in the pydocstyle doc). It shouldn't matter in the short-term I think? But we need to change that at some point. It should also be integrated into the CI/CD pipeline & dev-dependencies. But since the repo isn't ready to be tested in the by a docsting-tool ATM I don't think it's critical and needs to be changes in this PR.

Secondly, type-hints in docstrings are not needed if the signatures are typed (which should be the case in our repo). But I leave it up to you whether you wanna change that or not.

@anawas anawas merged commit 599d993 into main Feb 10, 2025
4 checks passed
@anawas anawas deleted the aw_update_docu branch February 10, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants