-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Documentation #639
Conversation
… can also be used elsewhere. ♊
…ined on line 258. Was mentioned by mpluess in PR #636 🚨
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
=======================================
Coverage 71.19% 71.19%
=======================================
Files 55 55
Lines 5946 5947 +1
=======================================
+ Hits 4233 4234 +1
Misses 1713 1713 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Two mentions:
Pydocstyle is deprecated, Ruff should be used instead (since you made changes in the pydocstyle doc). It shouldn't matter in the short-term I think? But we need to change that at some point. It should also be integrated into the CI/CD pipeline & dev-dependencies. But since the repo isn't ready to be tested in the by a docsting-tool ATM I don't think it's critical and needs to be changes in this PR.
Secondly, type-hints in docstrings are not needed if the signatures are typed (which should be the case in our repo). But I leave it up to you whether you wanna change that or not.
As we seem to be working towards a Karabo version 1.0 I'm about to update the documentation.
What I did so far: