Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_status_cols function #22

Merged
merged 2 commits into from
May 28, 2024
Merged

Add create_status_cols function #22

merged 2 commits into from
May 28, 2024

Conversation

andysontran
Copy link
Contributor

@andysontran andysontran commented May 23, 2024

Partial fix for issue #21

  • Functionalized initialization of sawmill_pass and sawmill_status columns in timber at the start of the check_grain function

  • Added to-do notes for build_chairs function

  • Updated .gitignore to include .DS_Store

  • Still need to implement in all submill functions (i.e., under mill.R: read_timber, debark, etc.?)

- Functionalized initialization of sawmill_pass and sawmill_status columns in timber at the start of the check_grain function
- Added to-do notes for build_chairs function
- Updated .gitignore to include .DS_Store
@andysontran andysontran requested a review from chapb May 23, 2024 17:05
- Added missing lines of code for validate_contingency_table function
@andysontran andysontran self-assigned this May 24, 2024
Copy link
Member

@chapb chapb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Unclear what triggered the update to sawmill.rd (perhaps bump to Roxygen?).
I haven't tested with timber.

@chapb chapb merged commit 5a2e90d into main May 28, 2024
@andysontran
Copy link
Contributor Author

Thanks for reviewing Brennan!

Looks good to me. Unclear what triggered the update to sawmill.rd (perhaps bump to Roxygen?).

I think you're right about the bump to Roxygen since the version number changed in sawmill.rd.

I haven't tested with timber.

Testing with example timber for all four grain types produces an error following the Reorder Fields function.

Error in value[3L] : ERROR in sawmill function:
Error in value[3L]: ERROR in Reorder Fields: reorder processed timber output columns. function:
Error in timber_del[field_names] at sawmill/R/reorder_fields.R:61:3:
! Can't subset columns that don't exist.
✖ Columns ID_meta and insensible_prev_table don't exist.

Not sure if you're experiencing the same error in the latest merge to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants