Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSP VTX Code Updates #10355

Merged
merged 21 commits into from
Nov 4, 2024
Merged

MSP VTX Code Updates #10355

merged 21 commits into from
Nov 4, 2024

Conversation

geoffsim
Copy link
Contributor

Current VTX Control from ELRS and FC is erratic.

The MSP VTX code, originally pulled from BF, was not properly integrated into iNav. This led to the "stealing" of VTX messages meant for the original FC VTX processing. Also, the FC message processing was incorrectly calling MSP VTX code directly rather than allowing the existing VTX support framework to process any changes to band/channel/power.

@MartinHugh
Copy link

probably related to or causing hd-zero/hdzero-vtx#203

Move telemetry function definition back to correct place.
Simplify initialisation.
@geoffsim
Copy link
Contributor Author

VTX band/channel/power/pitmode/lpmode can be changed in the FC VTX menu; the actual VTX menu; the programming tab; and the ELRS VTX lua script. If you use more than one of these methods, you may find discrepancies between what you think you have set and and what is actually set. For example, using a switch to set a power level of 1 can be overriden by a VTX menu or the ELRS lua. Only use one of these methods to get consistent results. Also, pit mode is not very well supported in iNav, and you may find issues when using it.

@geoffsim geoffsim marked this pull request as draft September 16, 2024 11:08
@geoffsim geoffsim marked this pull request as ready for review September 18, 2024 07:48
@geoffsim geoffsim marked this pull request as draft September 20, 2024 10:12
@geoffsim geoffsim marked this pull request as ready for review September 21, 2024 09:17
@geoffsim geoffsim marked this pull request as draft September 22, 2024 10:56
@mmosca mmosca added this to the 8.0 milestone Sep 24, 2024
@geoffsim
Copy link
Contributor Author

Caveats:

  1. Both PIT mode and LP Mode do not always work as expected on HDZERO. This will be addressed in a later PR.
  2. When using the programming tab to change band/channel/power (ex, using TX switches), using the OSD VTX menu will override these settings and will not show in the OSD menu. This will/may be addressed in a later PR.
  3. Setting a power level of 0 in the programming tab will result in the VTX power level to be set to 0mW, regardless of the arming mode.

@geoffsim geoffsim marked this pull request as ready for review September 26, 2024 13:24
@geoffsim geoffsim marked this pull request as draft September 26, 2024 14:00
@geoffsim geoffsim marked this pull request as ready for review September 27, 2024 15:29
@mmosca mmosca merged commit 78e1392 into iNavFlight:master Nov 4, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants