Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CCA Block syncing and PlayerLookup API #1645

Open
wants to merge 6 commits into
base: 1.21
Choose a base branch
from
Open

Fix CCA Block syncing and PlayerLookup API #1645

wants to merge 6 commits into from
+89 −12

Conversation

daimond113
Copy link

@daimond113 daimond113 commented Oct 26, 2024 •
edited
Loading

Fixes the following:

  • CCA block components not syncing due to the CCA mixin being indirectly (this method calls a method CCA mixins into) overwritten here
  • the PlayerLookup API from the Fabric API by overwriting the vanilla method of isChunkTracked and redirecting getPlayers and getPlayersCloseForSpawning to allow players outside the dimension to be included aswell.

@daimond113 daimond113 marked this pull request as draft October 28, 2024 18:41
@daimond113
Copy link
Author

I've just found that block entities placed/added after the chunk load still don't work. Will try to fix it soon.

@daimond113 daimond113 changed the title Fix Cardinal Components Block syncing Fix CCA Block syncing and PlayerLookup API Oct 30, 2024
@daimond113 daimond113 marked this pull request as ready for review October 30, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pyrofab Pyrofab Pyrofab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daimond113 @Pyrofab