-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(view): add WebXR support. #2092
Conversation
09fc019
to
cd9b9b3
Compare
No more feedback from my side. Just take a look of the previous ones to resolve them |
4cf649d
to
ec64d2b
Compare
@mgermerie @jogarnier I added some TODOs for the "asynchronization between I'll open a PR to replace calls to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's all good for me, except for one question on architecture : would it be possible to leave the VR button creation responsibility to user ? We would just have the sessionstart
event listener in src/Renderer/WebXR.js
and user would need to trigger this event with his/hers own button or three.js premade button.
The current behavior enforces user to use three.js button.
580daad
to
c985d7c
Compare
@mgermerie Following your comment, I moved the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no functional test on this example, but from what I remember from testing for ColladaLoader
, the functional tests fail with importmap
.
Description
Add WebXR partial support.
Features added
Work for the next PR
MainLoop.update
andvr.renderer
;