Fix C3DTilesLayer and C3DTFeature
#2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinMachado
force-pushed
the
fix-C3DTfeatures-init
branch
from
d0b60de to
6cdfd01
Compare
|
Great ! I've made a single commit, and CI is working. |
jailln
reviewed
Nov 8, 2023
valentinMachado
force-pushed
the
fix-C3DTfeatures-init
branch
2 times, most recently
from
e3bf3bb to
27ed48f
Compare
…C3DTFeature. BREAKING CHANGE: C3DTFeature constructor changed from (tileId, batchId, groups, info, userData) to (tileId, batchId, groups, info, userData, object3d)
valentinMachado
force-pushed
the
fix-C3DTfeatures-init
branch
from
27ed48f to
ecbc2bc
Compare
jailln
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
C3DTFeaturereference theTHREE.Object3Dwhere they belong.computeWorldBox3is now a method ofC3DTFeaturepossible due to the latter modificationSome code clean.
updateStyleis call after dispacthing eventON_TILE_CONTENT_LOADEDMotivation and Context
C3DTFeaturereference theTHREE.Object3Dwhere they belong.=> tileContent can have different child with feature in it which was not handle by the previous code
updateStyleis call after dispacthing eventON_TILE_CONTENT_LOADED=> when listener of this event influences
C3DTilesLayerstyle the user does not have to call an extraupdateStyleof the layerwaiting this to be approved to rename commits name