Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participant is not initialised correctly when loading from JSON #261

Conversation

NoB0
Copy link
Collaborator

@NoB0 NoB0 commented Aug 19, 2024

Update dialogue reader to initialize utterance participant to DialogueParticipant.

Fixes #260

Copy link

github-actions bot commented Aug 19, 2024

Unit Test Results

86 tests   86 ✔️  49s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit f645db0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 19, 2024

Coverage Report •
FileStmtsMissCoverMissing
dialoguekit/utils
   dialogue_evaluation.py104198%96, 154–>162
   dialogue_reader.py66292%70–>73, 84, 146
tests/utils
   test_dialogue_reader.py290100% 
TOTAL223620889% 

Copy link

Current Branch Main Branch
Coverage Badge Coverage Badge

The typing issue raised is covered earlier in the method by checking if all utterances are AnnotatedUtterance
Copy link
Contributor

@kbalog kbalog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoB0 NoB0 merged commit bcb64ed into main Aug 20, 2024
5 checks passed
@NoB0 NoB0 deleted the feature/260-Participant-is-not-initialised-correctly-when-loading-from-JSON branch August 20, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Participant is not initialised correctly when loading from JSON
2 participants