Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method _generate_elicit_response_intent_and_annotations #139

Merged

Conversation

NoB0
Copy link
Collaborator

@NoB0 NoB0 commented May 25, 2023

Implementation _generate_elicit_response_intent_and_annotations to generate intent and annotations of the next simulator's utterance when the recommender system elicits preferences.

After retrieving the elicited slot and value, based on these, the PreferenceModel returns of preference or not that is used to generate the corresponding intent.

Follow-up issues:

Fixes #135

@github-actions
Copy link

Current Branch Main Branch
Coverage Badge Coverage Badge

@NoB0 NoB0 marked this pull request as ready for review May 30, 2023 07:47
@NoB0 NoB0 requested a review from kbalog May 30, 2023 07:47
Copy link
Contributor

@kbalog kbalog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@NoB0 NoB0 merged commit 77a04e0 into main May 30, 2023
@NoB0 NoB0 deleted the feature/135-Refactor-generate_output-in-agenda_based_simulator branch May 30, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor generate_output in agenda_based_simulator
2 participants