This repository has been archived by the owner on Dec 6, 2023. It is now read-only.
Add options to avoid writing any files to disk #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork
The trace/debug enabled check should be done in the Write-methods and not every time the Write-method is called.
Lib will only write files to disk, if tracing is enabled.
codebude
pushed a commit
to codebude/libfintx
that referenced
this pull request
Mar 20, 2018
Add options to avoid writing any files to disk
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this issue #15 , I set all File.Write stuff (BPD, UPD, MT940) in dependency to the Trace.Enabled state. So sensitive data will only be written to disk, of the user/programmer chooses to do so.
In consequence of this, I added an Enabled-flag in the Log-class, too. So it is possible to avoid writing to disk at all.