Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcode for total # of visitors (e.g. a site counter) #120

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

intentionally-left-nil
Copy link
Contributor

This PR provides the ability to add the total # of visitors as a shortcode.
You can use it in your site (say in footer.php) with the following:

<span>
  Visitors:
  <?php
    echo do_shortcode('[koko_analytics_site_counter days=30]');
  ?>
</span>

If there's support for the PR I'm happy to clean it up, provide unit tests, support for pageviews vs visitors, etc.

Thanks!

@intentionally-left-nil
Copy link
Contributor Author

Hey @dannyvankooten, this PR has been sitting for awhile. Do you mind taking a look and giving feedback?

the number of times the whole site or a page has been viewed
@dannyvankooten dannyvankooten force-pushed the master branch 2 times, most recently from 4455173 to cd940fb Compare September 18, 2023 06:04
@dannyvankooten
Copy link
Member

Hey @intentionally-left-nil,

I'm so sorry for not seeing this before and not getting back until now. I really like the functionality you added here and hope to be able to take a closer look and merge this real soon. The final naming of things might differ a bit, but rest assured that the functionality will end up in the core plugin!

@dannyvankooten dannyvankooten merged commit 2a0eec0 into ibericode:master Feb 26, 2024
1 of 3 checks passed
@dannyvankooten
Copy link
Member

It's finally merged @intentionally-left-nil! Thank you for being so patient.

@intentionally-left-nil
Copy link
Contributor Author

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants