Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-9109: Enabling TypeScript (ts-loader) with Webpack Encore #1373

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

IBX-9109: Enabling TypeScript (ts-loader) with Webpack Encore #1373

wants to merge 4 commits into from

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Oct 17, 2024 •
edited
Loading

🎫 Issue IBX-9109

Related PRs:

Description:

Changes:

  1. Added configuration file for TypeScript
  2. Updated package.json to be able to interpret ts and tsx fiels via eslint and prettier

For QA:

Documentation:

@lucasOsti lucasOsti mentioned this pull request Oct 17, 2024
Open
@lucasOsti lucasOsti force-pushed the IBX-9109-enabling-typescript branch 5 times, most recently from 9add474 to 06aa620 Compare October 18, 2024 11:07
@lucasOsti lucasOsti mentioned this pull request Oct 18, 2024
Open
@lucasOsti lucasOsti force-pushed the IBX-9109-enabling-typescript branch 11 times, most recently from b6e11a5 to dc1a6cc Compare October 22, 2024 09:45
@lucasOsti lucasOsti requested a review from dew326 October 22, 2024 10:43
@lucasOsti lucasOsti changed the base branch from main to 4.6 October 25, 2024 10:11
@lucasOsti lucasOsti force-pushed the IBX-9109-enabling-typescript branch 2 times, most recently from c99e076 to 524ecba Compare October 29, 2024 11:40
@lucasOsti lucasOsti changed the base branch from 4.6 to main October 29, 2024 11:40
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

@dew326 dew326 Awaiting requested review from dew326

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

@tischsoic tischsoic Awaiting requested review from tischsoic

@bozatko bozatko Awaiting requested review from bozatko

Assignees

@mikadamczyk mikadamczyk

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lucasOsti @Steveb-p @tischsoic @bozatko @mikadamczyk @ciastektk @dew326 @ViniTou