Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-9169: Enable searching by content's name in the Trash #1388

Open
wants to merge 2 commits into
base: 4.6
Choose a base branch
from

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Nov 4, 2024

🎫 Issue IBX-9169

Related PRs:

ibexa/core#448

Description:

image

Copy link

sonarcloud bot commented Nov 4, 2024

@barw4 barw4 requested a review from a team November 4, 2024 13:06
@ViniTou
Copy link
Contributor

ViniTou commented Nov 4, 2024

However, as I understand why and this beeing low cost - question is should it just target 5.0 to be rules obidient.

@barw4
Copy link
Contributor Author

barw4 commented Nov 4, 2024

@ViniTou it's highly requested unfortunately lately so I think we need to bend the rules a bit here

Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a really great feature! I think we should switch the position of "Content name" and "Creator" fields as well as remove "Content name" label to align filters in trash to design system, for example:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature request Ready for QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants