Extracted common base for TextBlock and TextLine field types #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
approved these changes
Jul 17, 2024
konradoboza
approved these changes
Jul 18, 2024
Steveb-p
reviewed
Aug 5, 2024
alongosz
force-pushed
the
ibx-8138/fieldtype-text-line-block-dry-fix
branch
from
84b5e6b
to
fa2d717
Compare
Co-Authored-By: Paweł Niedzielski <[email protected]>
alongosz
force-pushed
the
ibx-8138/fieldtype-text-line-block-dry-fix
branch
from
fa2d717
to
2b4d468
Compare
|
barw4
pushed a commit
that referenced
this pull request
Oct 17, 2024
For more details see #406 Key changes: * Extracted common base for TextBlock and TextLine field types * [Tests] Aligned tests with TextBlock and TextLine changes * [Tests] Reduced complexity of TextBlock and TextLine test classes * [PHPStan] Aligned baseline with the changes --------- Co-authored-by: Paweł Niedzielski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR addresses one of the many code redundancy issues found by SonarCloud while working on #385.
☝️ because of that we can have a common base type-hinting just on TextValue contravariant base type.
For QA:
Regression build should be enough (ibexa/commerce#1006).