Extracted common code for Binary and Media field type #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
changed the title
alongosz
force-pushed
the
ibx-8138/tests-fieldtype-binary-base-dry-fix
branch
from
94a026d
to
f110dc0
Compare
adamwojs
approved these changes
Jul 17, 2024
konradoboza
approved these changes
Jul 18, 2024
mikadamczyk
approved these changes
Jul 18, 2024
tests/integration/Core/Repository/FieldType/MediaIntegrationTest.php
Outdated
Show resolved
Hide resolved
|
Co-Authored-By: Adam Wójs <[email protected]>
Co-Authored-By: Mikolaj Adamczyk <[email protected]>
alongosz
force-pushed
the
ibx-8138/tests-fieldtype-binary-base-dry-fix
branch
from
a9ba9c8
to
22d876c
Compare
|
This was referenced Aug 26, 2024
ms2ad
pushed a commit
to ms2ad/ibexa-core
that referenced
this pull request
Aug 26, 2024
…:loadLocationChildren` (ibexa#407) For more details see https://issues.ibexa.co/browse/IBX-8019 and ezsystems/ezplatform-kernel#407
barw4
pushed a commit
that referenced
this pull request
Oct 17, 2024
For more details see #407 Key changes: * Extracted redundant Binary and Media SearchField into a common base * [Tests] Extracted common base for Binary and Media ft integration tests * [Tests] Made MediaIntegrationTest::getValidFieldSettings return type more strict * [PHPStan] Aligned baseline with the changes --------- Co-authored-by: Adam Wójs <[email protected]> Co-authored-by: Mikolaj Adamczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR addresses one of the many code redundancy issues found by SonarCloud while working on #385.
We already define
BinaryBasefor Media and Binary files, so related code & tests should rely on that.For QA:
Regression tests should be enough (ibexa/commerce#1004).