IBX-9415: Added support for ContentAwareInterface in ibexa_* Twig functions #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiewiurdp
added
Doc needed
ViniTou
reviewed
Jan 28, 2025
| @@ -4,6 +4,7 @@ | |||
| {% extends 'templates/base.html.twig' %} | |||
| {% block content %} | |||
| {{ ez_render_field( nooverride, 'testfield' ) }} | |||
| {{ ibexa_render_field( contentaware, 'testfield' ) }} | |||
There was a problem hiding this comment.
shouldnt you be testing {{ ez_render_field( contentaware, 'testfield' ) }} here and in other ez_ fixtures?
| new TwigFunction( | ||
| 'ibexa_field_is_empty', | ||
| [$this, 'isFieldEmpty'] | ||
| ), | ||
| new TwigFunction( |
There was a problem hiding this comment.
minor, but there is no need to change it position in the array and complicate eventual merge up where all ez_ functions are dropped.
src/lib/MVC/Symfony/Templating/Twig/Extension/ContentExtension.php
Outdated
Show resolved
Hide resolved
ViniTou
changed the title
alongosz
changed the title
adamwojs
approved these changes
Feb 2, 2025
alongosz
reviewed
Feb 3, 2025
| * @param string $forcedLanguage Locale we want the content name translation in (e.g. "fre-FR"). Null by default (takes current locale) | ||
| * | ||
| * @throws \Ibexa\Core\Base\Exceptions\InvalidArgumentType When $content is not a valid Content or ContentInfo object. | ||
| * @throws \Ibexa\Core\Base\Exceptions\InvalidArgumentType When $content is not a valid Content, ContentInfo or ContentAwareInterface object. |
There was a problem hiding this comment.
punctuation, use Oxford comma please (yes, the punctuation here was incorrect before):
Suggested change
| * @throws \Ibexa\Core\Base\Exceptions\InvalidArgumentType When $content is not a valid Content, ContentInfo or ContentAwareInterface object. | |
| * @throws \Ibexa\Core\Base\Exceptions\InvalidArgumentType When $content is not a valid Content, ContentInfo, or ContentAwareInterface object. |
src/lib/MVC/Symfony/Templating/Twig/Extension/ContentExtension.php
Outdated
Show resolved
Hide resolved
ViniTou
approved these changes
Feb 3, 2025
added 2 commits
February 4, 2025 12:15
alongosz
approved these changes
Feb 4, 2025
added 3 commits
February 4, 2025 13:31
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Added support for ContentAwareInterface objects (e.g. product) to following Twing functions
For QA:
It needs to be chcked if all theses functions can instead of
contentas a first argument also work with for exampleproductDocumentation:
Docs for all theses functions should be changed that they are working also with ContentAwareInterfaced objects