Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6415: Renamed domain names #72

Merged
merged 1 commit into from
Sep 5, 2023
Merged

IBX-6415: Renamed domain names #72

merged 1 commit into from
Sep 5, 2023

Conversation

mikadamczyk
Copy link
Contributor

Question Answer
JIRA issue IBX-6415
Type improvement
Target version v4.6
BC breaks yes
Tests pass yes
Doc needed no

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mikadamczyk mikadamczyk requested review from konradoboza and a team September 5, 2023 10:11
@mikadamczyk mikadamczyk self-assigned this Sep 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza requested a review from a team September 5, 2023 10:18
@alongosz alongosz merged commit 644878d into main Sep 5, 2023
11 of 12 checks passed
@alongosz alongosz deleted the renamed-domain-names branch September 5, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikadamczyk @alongosz @konradoboza @Steveb-p @ViniTou