Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PHPStan #80

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fixed PHPStan #80

merged 1 commit into from
Dec 7, 2023

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Dec 7, 2023

Question Answer
JIRA issue N/A
Type bug
Target version Ibexa v4.5

Fixes PHPStan by regenerating baseline.

Fixing the issue in question in tests causes subsequent errors to occur (steming from invalid annotations). To quickly address this issue for CI purposes I recommend adding it to baseline.

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@Steveb-p Steveb-p requested a review from a team December 7, 2023 07:25
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adamwojs adamwojs merged commit fc24367 into 4.5 Dec 7, 2023
12 checks passed
@adamwojs adamwojs deleted the fix-phpstan-baseline branch December 7, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@ciastektk ciastektk ciastektk approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

Labels
Improvement Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Steveb-p @adamwojs @mikadamczyk @ciastektk @alongosz @ViniTou