Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed phpstan errors #85

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Fixed phpstan errors #85

merged 1 commit into from
Mar 26, 2024

Conversation

tischsoic
Copy link
Contributor

Question Answer
JIRA issue -
Type -
Target version e.g.: Ibexa v4.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@tischsoic tischsoic self-assigned this Mar 26, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tischsoic tischsoic marked this pull request as ready for review March 26, 2024 15:45
@tischsoic tischsoic requested a review from a team March 26, 2024 15:47
@konradoboza konradoboza requested a review from a team March 26, 2024 15:49
@alongosz alongosz merged commit a6db3ae into 4.5 Mar 26, 2024
11 checks passed
@alongosz alongosz deleted the fix-phpstan-4-5 branch March 26, 2024 16:02
@tischsoic
Copy link
Contributor Author

Merged up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@tischsoic tischsoic

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tischsoic @alongosz @konradoboza @Steveb-p @ViniTou